Skip to content

Add function that checks if function id represents a clinit. #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2019
Merged

Add function that checks if function id represents a clinit. #4706

merged 2 commits into from
May 29, 2019

Conversation

jeannielynnmoulton
Copy link
Contributor

@jeannielynnmoulton jeannielynnmoulton commented May 24, 2019 •
edited
Loading

A utility for checking whether the supplied function id corresponds to a
clinit.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

thomasspriggs
thomasspriggs approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test, as well please. You know it makes sense :)

allredj
allredj reviewed May 24, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 7f1830e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113106427

smowton
smowton suggested changes May 24, 2019
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, no unused code in the cbmc codebase please :)

@jeannielynnmoulton
Add function that checks if function id represents a clinit.
47a8f4e 
A utility for checking whether the supplied function id corresponds to a
clinit.
@jeannielynnmoulton
Copy link
Contributor Author

@smowton No problem, added.

@smowton
Copy link
Contributor

smowton commented May 28, 2019

Add to https://github.com/diffblue/cbmc/blob/develop/jbmc/unit/Makefile

@jeannielynnmoulton
Unit test for is_clinit_function
c227ab5 
Shows that is_clinit_function returns true iff input has method signature with a suffix that matches that of clinit
allredj
allredj reviewed May 28, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: c227ab5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113421780

@jeannielynnmoulton jeannielynnmoulton merged commit 4b1352e into diffblue:develop May 29, 2019
@jeannielynnmoulton jeannielynnmoulton deleted the jeannie/ClinitCheck branch May 29, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@LAJW LAJW LAJW approved these changes

@thomasspriggs thomasspriggs thomasspriggs approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@thk123 thk123 Awaiting requested review from thk123

Assignees

@smowton smowton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeannielynnmoulton @smowton @LAJW @allredj @thomasspriggs